Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Klingon (tlh) Translation to the Application. #89

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

EliasDeHondt
Copy link
Owner

@EliasDeHondt EliasDeHondt commented Feb 20, 2025

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person who created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@EliasDeHondt EliasDeHondt added the In Progress Work on this issue or task is currently ongoing. label Feb 20, 2025
@EliasDeHondt EliasDeHondt requested a review from VW03 February 20, 2025 21:10
@EliasDeHondt EliasDeHondt self-assigned this Feb 20, 2025
@VW03 VW03 added Closed The issue or task has been completed or resolved. and removed In Progress Work on this issue or task is currently ongoing. labels Feb 21, 2025
@VW03 VW03 merged commit 14cdf40 into main Feb 21, 2025
7 checks passed
@VW03 VW03 deleted the klingon-translation branch February 21, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants