Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment through app #84

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Deployment through app #84

merged 12 commits into from
Feb 19, 2025

Conversation

Meastro85
Copy link
Collaborator

@Meastro85 Meastro85 commented Feb 17, 2025 •
edited by VW03
Loading

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person who created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@EliasDeHondt EliasDeHondt requested a review from VW03 February 17, 2025 17:06
@EliasDeHondt EliasDeHondt added the In Progress Work on this issue or task is currently ongoing. label Feb 17, 2025
@VW03 VW03 added Closed The issue or task has been completed or resolved. and removed In Progress Work on this issue or task is currently ongoing. labels Feb 19, 2025
@Meastro85
Merge branch 'main' of https://github.com/EliasDeHondt/K10s into Depl…
5f5db40 
…oyment-through-app

# Conflicts:
#	App/Backend/cmd/kubernetes/handlers/GetConfigMaps.go
#	App/Backend/cmd/kubernetes/handlers/GetDeployments.go
#	App/Backend/cmd/kubernetes/handlers/GetNodes.go
#	App/Backend/cmd/kubernetes/handlers/GetPods.go
#	App/Backend/cmd/kubernetes/handlers/GetSecrets.go
#	App/Backend/cmd/kubernetes/handlers/GetServices.go
#	App/Backend/testing/get_handler_test.go
@VW03 VW03 merged commit 5e1e15a into main Feb 19, 2025
7 checks passed
@VW03 VW03 deleted the Deployment-through-app branch February 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VW03 VW03 VW03 approved these changes

Assignees

@Meastro85 Meastro85

Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meastro85 @VW03 @EliasDeHondt