Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72 task investigate cluster visualizations #76

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

VW03
Copy link
Collaborator

@VW03 VW03 commented Feb 14, 2025

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person who created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@VW03 VW03 linked an issue Feb 14, 2025 that may be closed by this pull request
1 task
@VW03 VW03 self-assigned this Feb 14, 2025
VeraWise added 2 commits February 14, 2025 09:38
# Conflicts:
#	App/Frontend/src/app/app.routes.ts
#	App/Frontend/src/app/dashboard/dashboard.component.ts
@EliasDeHondt EliasDeHondt added the In Progress Work on this issue or task is currently ongoing. label Feb 14, 2025
@VW03 VW03 removed the In Progress Work on this issue or task is currently ongoing. label Feb 14, 2025
@EliasDeHondt
Copy link
Owner

INFO FORM @VW03

tested d3.js lib and @angular/cdk/drag-drop --> both have same problem with component in component integration + more errors (I drag a node and it dissapears ..) --> will stay on canvas (easy export too)

https://observablehq.com/@d3/d3-hierarchy
https://material.angular.io/cdk/drag-drop/api

@EliasDeHondt EliasDeHondt added the In Progress Work on this issue or task is currently ongoing. label Feb 15, 2025
VeraWise added 2 commits February 16, 2025 20:26
# Conflicts:
#	App/Frontend/package-lock.json
#	App/Frontend/src/app/dashboard/dashboard.component.ts
@EliasDeHondt EliasDeHondt added Closed The issue or task has been completed or resolved. and removed In Progress Work on this issue or task is currently ongoing. labels Feb 19, 2025
# Conflicts:
#	App/Frontend/src/app/app.routes.ts
#	App/Frontend/src/app/dashboard/dashboard.component.ts
@Meastro85 Meastro85 merged commit 8aae83e into main Feb 19, 2025
7 checks passed
@Meastro85 Meastro85 deleted the 72-task-investigate-cluster-visualizations branch February 19, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK]: Investigate cluster visualizations.
3 participants