Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 Add video, pitch, and photo sections to documentation #54

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

EliasDeHondt
Copy link
Owner

@EliasDeHondt EliasDeHondt commented Feb 5, 2025

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person whe created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@EliasDeHondt EliasDeHondt added the Open The issue or task is created and awaiting attention. label Feb 5, 2025
@EliasDeHondt EliasDeHondt requested a review from VW03 February 5, 2025 15:18
@EliasDeHondt EliasDeHondt self-assigned this Feb 5, 2025
@EliasDeHondt EliasDeHondt merged commit c51c160 into main Feb 5, 2025
6 checks passed
@EliasDeHondt EliasDeHondt added Closed The issue or task has been completed or resolved. and removed Open The issue or task is created and awaiting attention. labels Feb 5, 2025
@EliasDeHondt EliasDeHondt deleted the GitHub-VideoAndPitchAndPhotos-Docs branch February 19, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant