add Darija (Moroccan dialects) tasks including darijammlu. darijahellaswag and darija_bench #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadi-abdine
requested review from
baberabb and
lintangsutawika
as code owners
|
|
|
Hi! looks good to commit if you could run the pre-commit. Also are all the benchmarks machine translated? maybe we could add that to the language column in |
|
Hi! LGTM! Could you merge to the current main to resolve the conflict. |
baberabb
requested changes
Jan 28, 2025
lm_eval/tasks/darija_bench/darija_summarization/summarization_common_yaml
Show resolved
Hide resolved
lm_eval/tasks/darija_bench/darija_summarization/summarization.yaml
Outdated
Show resolved
Hide resolved
|
Hi @hadi-abdine. The recursion error is due to the summarization tasks. I think the changes i identified should fix it |
|
Hello @baberabb. Thank you for the review, I just fixed the issue causing the recursion error in the summarization task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.