add dublin_tcd number (#512)

ElectronicBabylonianLiterature · Nov 25, 2024 · 7ae09da · 7ae09da
1 parent 0a99bc6
commit 7ae09da
Show file tree

Hide file tree

Showing 10 changed files with 91 additions and 46 deletions.
diff --git a/src/fragmentarium/domain/Fragment.test.ts b/src/fragmentarium/domain/Fragment.test.ts
@@ -129,6 +129,7 @@ const config: Parameters<typeof Fragment['create']>[0] = {
     nabuccoNumber: '123',
     metropolitanNumber: '123',
     louvreNumber: '123',
+    dublinTcdNumber: '123',
     alalahHpmNumber: '123',
     australianinstituteofarchaeologyNumber: '123',
     philadelphiaNumber: '123',

diff --git a/src/fragmentarium/domain/FragmentDtos.ts b/src/fragmentarium/domain/FragmentDtos.ts
@@ -74,6 +74,7 @@ export const ExternalNumberTypes = [
   'nabuccoNumber',
   'metropolitanNumber',
   'louvreNumber',
+  'dublinTcdNumber',
   'alalahHpmNumber',
   'australianinstituteofarchaeologyNumber',
   'philadelphiaNumber',

diff --git a/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap b/src/fragmentarium/ui/front-page/__snapshots__/LatestTransliterations.test.tsx.snap
@@ -37,11 +37,11 @@ exports[`Snapshot 1`] = `
               </p>
               <p>
                 Excavation no.: 
-                ed.1
+                waloub.1
               </p>
               <p>
                 Provenance: 
-                Dugirdkhan
+                Dilbat
               </p>
             </small>
           </div>
@@ -5851,9 +5851,9 @@ exports[`Snapshot 1`] = `
             class="fragment-result__fragment-number"
           >
             <a
-              href="/fragmentarium/etkoclo.2"
+              href="/fragmentarium/hapbig.2"
             >
-              etkoclo.2
+              hapbig.2
             </a>
              (JN)
           </h4>
@@ -5863,15 +5863,15 @@ exports[`Snapshot 1`] = `
             <small>
               <p>
                 Accession no.: 
-                baj.2
+                pehuvu.2
               </p>
               <p>
                 Excavation no.: 
-                jil.2
+                uf.2
               </p>
               <p>
                 Provenance: 
-                Tall Imlīḥiyah
+                Ḫuzirina
               </p>
             </small>
           </div>
@@ -5899,7 +5899,17 @@ exports[`Snapshot 1`] = `
             <li
               class="Record__entry"
             >
-              No record
+              Cavallini
+               (
+              Transliteration
+              ,
+               
+              <time
+                datetime="2061-06-11"
+              >
+                11/6/2061
+              </time>
+              )
             </li>
           </ol>
         </div>
@@ -5963,14 +5973,14 @@ exports[`Snapshot 1`] = `
                 <span
                   class="reference-popover__citation"
                 >
-                  Chirici & Borchi, 2066: 1964069523292160-4777479967342592 
+                  Chirici & Borchi, 2055: 851575803215872-8906036102561792 
                   [
-                  l. 4'.2., 2.
+                  l. 1., 2.
                   ]
                   <span
                     class="type-abbreviation"
                   >
-                     (T)
+                     (D)
                   </span>
                 </span>
               </li>

diff --git a/src/fragmentarium/ui/info/ExternalNumberLink.tsx b/src/fragmentarium/ui/info/ExternalNumberLink.tsx
@@ -143,6 +143,15 @@ export function LouvreLink({ number }: { number: string }): JSX.Element {
     />
   )
 }
+export function dublinTcdLink({ number }: { number: string }): JSX.Element {
+  return (
+    <ExternalNumberLink
+      number={number}
+      baseUrl={'https://digitalcollections.tcd.ie/concern/works/'}
+      label={'Trinity College Dublin'}
+    />
+  )
+}
 export function alalahHpmLink({ number }: { number: string }): JSX.Element {
   return (
     <ExternalNumberLink

diff --git a/src/fragmentarium/ui/info/ExternalResources.test.tsx b/src/fragmentarium/ui/info/ExternalResources.test.tsx
@@ -18,6 +18,7 @@ const achemenetNumber = 'H00744'
 const nabuccoNumber = 'H00765'
 const metropolitanNumber = 'M123'
 const louvreNumber = 'L123'
+const dublinTcdNumber = 'L123'
 const alalahHpmNumber = 'L123'
 const australianinstituteofarchaeologyNumber = 'L123'
 const philadelphiaNumber = 'P123'
@@ -44,6 +45,7 @@ describe('external resources', () => {
             nabuccoNumber,
             metropolitanNumber,
             louvreNumber,
+            dublinTcdNumber,
             alalahHpmNumber,
             australianinstituteofarchaeologyNumber,
             philadelphiaNumber,
@@ -92,6 +94,11 @@ describe('external resources', () => {
       metropolitanNumber,
     ],
     ['Louvre', 'https://collections.louvre.fr/ark:/53355/', louvreNumber],
+    [
+      'Trinity College Dublin',
+      'https://digitalcollections.tcd.ie/concern/works/',
+      dublinTcdNumber,
+    ],
     [
       'Alalah HPM Number',
       'https://www.hethport.uni-wuerzburg.de/Alalach/bildpraep.php?fundnr=',
@@ -147,6 +154,7 @@ describe('missing external resources', () => {
     'NaBuCCo',
     'The Metropolitan Museum of Art',
     'Louvre',
+    'Trinity College Dublin',
     'Alalah HPM Number',
     'Australian Institute of Archaeology',
     'Penn Museum',

diff --git a/src/fragmentarium/ui/info/ExternalResources.tsx b/src/fragmentarium/ui/info/ExternalResources.tsx
@@ -13,6 +13,7 @@ import {
   NabuccoLink,
   MetropolitanLink,
   LouvreLink,
+  dublinTcdLink,
   alalahHpmLink,
   australianinstituteofarchaeologyLink,
   PhiladelphiaLink,
@@ -54,6 +55,7 @@ export default function ExternalResources({
     [fragment.getExternalNumber('nabuccoNumber'), NabuccoLink],
     [fragment.getExternalNumber('metropolitanNumber'), MetropolitanLink],
     [fragment.getExternalNumber('louvreNumber'), LouvreLink],
+    [fragment.getExternalNumber('dublinTcdNumber'), dublinTcdLink],
     [fragment.getExternalNumber('alalahHpmNumber'), alalahHpmLink],
     [
       fragment.getExternalNumber('australianinstituteofarchaeologyNumber'),

diff --git a/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap b/src/fragmentarium/ui/info/__snapshots__/ExternalResources.test.tsx.snap
@@ -149,6 +149,18 @@ exports[`external resources Snapshot 1`] = `
       </a>
       )
     </li>
+    <li>
+      Trinity College Dublin (
+      <a
+        aria-label="Trinity College Dublin text L123"
+        href="https://digitalcollections.tcd.ie/concern/works/L123"
+        rel="noopener noreferrer"
+        target="_blank"
+      >
+        L123
+      </a>
+      )
+    </li>
     <li>
       Alalah HPM Number (
       <a