Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Tracer Span.addLinks, for dynamically linking spans #4465

Open
wants to merge 2 commits into
base: next-minor
Choose a base branch
from

Conversation

tim-smart
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 184d060

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@effect/opentelemetry Major
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/ai Major
@effect/ai-anthropic Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor February 17, 2025 01:14
@effect-bot effect-bot force-pushed the next-minor branch 4 times, most recently from 1be5dbd to 4ec16d6 Compare February 18, 2025 16:48
@mikearnaldi
Copy link
Member

mikearnaldi commented Feb 18, 2025

maybe Effect.spanAddLink(), or even Effect.link()

@tim-smart
Copy link
Contributor Author

maybe Effect.spanAddLink(), or even Effect.link()

We already have:

  • Effect.linkSpan
  • Effect.annotateSpan
  • Effect.annotateCurrentSpan

So we just need an api for linking to the current span (not regional)

Effect.linkCurrentSpan or Effect.linkToCurrentSpan were some options.

@mikearnaldi
Copy link
Member

  • Effect.linkSpan

we don't have Effect.linkSpan we have Effect.linkSpans, we will need to re-think naming in 4.0 as it's very unclear from the name what Effect.linkSpans does, probably something like Effect.addLinkToChildSpans or similar

@effect-bot effect-bot force-pushed the next-minor branch 4 times, most recently from 0a08be2 to d1e0854 Compare February 21, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

3 participants