-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crossover_BUY order and Cross_under SELL order for market order and trailing limit orders) #20
Comments
@ingnelson Hey, if I understand correctly, crossover-market-buy would mean, that it would place a market order when the price crosses your set price, and crossover-trailing-buy, the same thing, but with a trailing order? This feature looks pretty simple, maybe I will be implement it in a day or two. |
@Effanuel yes , for market order and trailing order. The client select the order type. crossover_buy = it triggers only and only when the current price cross from down to up the set-up price . Example crossover_buy : current price = $1010 So the price goes down to $ 999.5 nothing happen, but if the prices goes up again to 1000 , the program execute the crossover_buy automatically. Example crossunder_sell: Crossunder_sell = it triggers only and only when the current prices cross from up to down the set-up price . current price = $1000 So the price goes up to $ 1009.5 nothing happen, but if the prices goes down again to 1009 , the program execute the crossunder_sell automatically. Note : as you see it is not a simple cross price, it has a rule. This is the reason for crossover and crossunder. This is more than great !!! |
Ok, this may be a little more complex. I'll post here as soon as I get some kind of a working prototype. |
@Effanuel perfect, first think if there is a way to do it like I said . Check this repository , maybe it can give you a idea how to implement the crossover and crossunder. https://github.com/amaduskar/MACD-Based-Trading-Strat/blob/master/MACD%20Based%20Trading%20(1).ipynb By the way : Crossover_buy: 1)If the current price is "below" the set price , so the program execute the order when the current price touch the set price. What do you think ? This is a chunk or no so good way do it , right ? Only you know how to implement it , I would like your hear your comments, please. |
@ingnelson Yup, my idea was the same. Just instead of |
@Effanuel one last question, just to be sure: if the current price is above the set price , the program need 2 times cross . sell cross order : if the current price is above the set price , the program need 1 time cross . This way we can trade for counter trend trades (the first picture i uploaded on the second message) and break trades. too. breakup trade example: |
@ingnelson Yes, this is exactly how it would work. The only thing I have a question about is it better to use |
@Effanuel i think about that too. on 2 times cross : on 1 time cross: it would be interesting make a test. |
@Effanuel If you create 2 bitmex account and place the order on the same price : |
I have made an initial implementation on |
@Effanuel could you give all the command i need to type to check or update the cross-order , please ? i do not know how to do it . git clone https://github.com/Effanuel/BitMEX-scaled-orders/tree/Cross-Orders How i do it ? i am not so good with github. then use the other command to install everything again ? |
Just download zip from here https://github.com/Effanuel/BitMEX-scaled-orders/archive/Cross-Orders.zip, and do the same steps you would normally do: --put API keys in .env file--
cd api/
npm run init:packages
npm run build
npm run prod With |
@Effanuel i just try it , the cross order works like you said :) |
@ingnelson How is this different from stop market and take profit order? |
@Poilaucul this feature (cross order) could be use as OCO/OSO too. OCO/OSO = stop-market without close-on-trigger This new feature has a improvement example when the trader need to buy when the current price is above the set price (2 times cross), because the order always be executed when the current price cross from down to up :) , so we can place the order ahead on time. We just want to know which order is executed more faster : |
From what I can see, placing a stop-market order instead of letting the program execute market order is faster. |
@Effanuel this is my final thought: on buy order and current price is below the set price : it is better placing a stop-market order without close-on-trigger. on buy order and current price is above the set price : it is better the program execute the market order after the second cross, because if there is a wick or trail move on the set price we are sure the order is going to be execute it. This are the best options for this orders types. |
I think we can improve performance, by reducing subscriptions to tickers. const subscribe = instrumentTopics(SYMBOLS.XBTUSD, SYMBOLS.ETHUSD, SYMBOLS.XRPUSD); Try to replace it with this: const subscribe = instrumentTopics(SYMBOLS.XBTUSD); It should then subscribe to only |
Just change the line and do: cd api/
npm run clean
npm run build
npm run prod
|
@Effanuel i have testing it all the day the cross feature and i see that placing a stop-market order without close-on-trigger is better because it execute faster the order . when program execute the market order after the second cross the price moved too much. So the best option is place the stop-market order without close-on-trigger after the first cross for buy order and current price is below the set price and sell order and current price is above the set price. on the buy order and current price is above the set price and sell order and current price is below the set price , place the stop-market order without close-on-trigger right away. |
@Effanuel I love crossover or crossunder orders :) . Btc like to visit those areas , I think for this reason :
|
Hi! Very intresting project in my eyes. Thanks for sharing. Creating an optimized production build... ./src/containers/CrossOrder/CrossOrderContainer.tsx I'm not sure if its an error on my side or yours. Any input is very appriciated. |
Hey, sorry for late response. I have been very busy past this month. I will take a look at the problem you are having and will try to release this feature officially tomorrow, which is about 23 hours from this message. @andy1245 |
Pushed changes to |
@Effanuel Hello master.
Could you add a new feature like this one:
Crossover_BUY and Cross_under SELL ( for market order and trailing limit orders)
.Bitmex website has a more or less this feature , but it is manually. It is using "Stop Market , but unchecking close on trigger box "
The program has to save in memory this order or algorithm and execute it when the market achieve that rule (crossover and crossunder) on the selected price ?
I know that every feature you had launched have the best quality .
This features help the traders have more possibility to have a win trade, because the trade is excecuted on the market trend .
This feature help when traders use strategies like these ones :
I think many people is going to use it, i think it is very useful.
Now that you have Maket orders and Trailing orders would be a little more easy for you.
This orders or algorithm help a lot ; this is a logic and useful feature .
I will wait your reply.
The text was updated successfully, but these errors were encountered: