Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about API keys setup. #19

Open
Poilaucul opened this issue Aug 19, 2020 · 3 comments
Open

Question about API keys setup. #19

Poilaucul opened this issue Aug 19, 2020 · 3 comments

Comments

@Poilaucul
Copy link

Hello,

You need to set API keys before building the application.
This means that .env file is of no use after npm build ? If so the private API key being "built into" the package could cause some privacy issues, that is if you plan to add containers as a deployment method down the road.
Maybe add an option to force using the .env file?

BTW did that behavior change beetwen 1.7.1 and 1.7.2? It used to work with .env file being binded after npm build and now I get

Missing API Key

Regards,

@Effanuel
Copy link
Owner

v1.7.1 had .env file with keys in the /api directory. While this solution is good, you can't import files outside client/src directory if you have create-react-app application.

Basically moving the .env file to client/ directory solved this issue #5 .

I think this behaviour changed because of that.

@Poilaucul
Copy link
Author

Poilaucul commented Aug 22, 2020

Placed .env file in /api and /client, executed clean and build, still got the "Missing API key" error.

@Effanuel
Copy link
Owner

Effanuel commented Aug 2, 2021

Right now, I am implementing a way to setup the api keys through the applications itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants