Reorganize & clean exchange-rate logic #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
approved these changes
Feb 8, 2025
Pull request #5423 contained a bunch of logic errors, so clean everything up in a way that makes it less confusing and less buggy. - Break up long lines. - Fix misleading comments. - Give variables better names. - Don't copy data needlessly. - Stomp old cache entries instead of mutating them. - Only add the account fiat pair once, instead of in two separate places. - Expire cache entries once a load-time, instead of doing this in three separate places. - Do not store reverse rates in the cache, but derive them at the very end.
swansontec
force-pushed
the
william/fix-rate-cache
branch
from
24782fe to
d47fe40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #5423 contained a bunch of logic errors, so clean everything up in a way that makes it less confusing and less buggy.
getYesterdayDateRoundDownHourinto this file, since it's only used here.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: