Fix 2FA/otp Reminder Notification #5445
Merged
+148
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Feb 10, 2025
| const { notifState, accountNotifDismissInfo } = useAccountSettings() | ||
| const { lastChecked, dontAsk } = useOtpSettings() |
There was a problem hiding this comment.
The variable names are pretty generic, and this component deals with a lot of unrelated stuff. We should make it clear that they pertain to OTP, specifically. I would either do:
const optSettings = useOtpSettings()
... optSettings.dontAsk ...Or I would do:
const { lastChecked: otpLastChecked, dontAsk: otpDontAsk } = useOtpSettings()Either way is fine.
- Isolate the modals to their own file - Create a hook to ensure changes to otp disk settings are picked up by the `NotificationService` - Pull all logic for otp reminder notification state into `NotificationService`
Jon-edge
force-pushed
the
jon/fix/2fa-notif
branch
from
f358f4b to
c09cf92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
NotificationServiceNotificationServiceCHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: