Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useSelector calls for accessing non-existent exchangeRates #5440

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix useSelector calls for accessing non-existent exchangeRates #5440

wants to merge 1 commit into from

Conversation

Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Jan 31, 2025 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

peachbits
peachbits approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but change the changelog entry to note that we're now using a safe fallback 0 value for rates that don't exist. Internet connectivity isn't relevant to the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peachbits peachbits peachbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jon-edge @peachbits