Fix buy sell list #4765
Merged
Fix buy sell list #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paullinator
force-pushed
the
paul/fixBuySellList
branch
from
3b61531 to
42722e1
Compare
samholmes
approved these changes
Jan 26, 2024
Comment on lines
+439
to
+440
| // XXX: Hack. paddingBottom from insetStyle is not sufficient. | ||
| contentContainerStyle={{ ...insetStyle, paddingBottom: theme.rem(6) }} |
There was a problem hiding this comment.
Why is it not sufficient? What's causing this?
There was a problem hiding this comment.
I don't know but I'm NOT touching common code in the SceneWrapper this late in the game.
- Do not use SectionView but just a DividerLine - Revert from using `overflow: 'visible'` due to bug on Android and use insets given by SceneWrapper instead.
paullinator
force-pushed
the
paul/fixBuySellList
branch
from
42722e1 to
9d45622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overflow: 'visible'due to bug on Android and use insets given by SceneWrapper instead.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: