Fix NotificationView positioning #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/notification-view-position
branch
from
a748151 to
929e989
Compare
Jon-edge
approved these changes
Jan 25, 2024
paullinator
force-pushed
the
sam/notification-view-position
branch
from
929e989 to
6c2cd07
Compare
samholmes
force-pushed
the
sam/notification-view-position
branch
from
6c2cd07 to
6aac66b
Compare
The NotificationView should be rendered outside of the keyboard tracking so it doesn't move when the keyboard is open.
samholmes
force-pushed
the
sam/notification-view-position
branch
from
6aac66b to
a73aa08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: