Fix margins and insets on Home scene #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/home-scene-margins
branch
from
19e12f1 to
b789f98
Compare
|
Broken on Android |
samholmes
force-pushed
the
sam/home-scene-margins
branch
2 times, most recently
from
147f2d5 to
b87f4da
Compare
Jon-edge
requested changes
Jan 25, 2024
samholmes
force-pushed
the
sam/home-scene-margins
branch
2 times, most recently
from
f879682 to
3ffdc75
Compare
Jon-edge
force-pushed
the
sam/home-scene-margins
branch
from
3ffdc75 to
3d50694
Compare
Jon-edge
approved these changes
Jan 26, 2024
samholmes
commented
Jan 27, 2024
| onScroll={handleScroll} | ||
| /> | ||
| </View> | ||
| {({ insetStyle }) => ( |
There was a problem hiding this comment.
This change would break the "underflow" of the scroll for this scene. Did you test to see if the tx list scene appears underneath tabs and header?
| @@ -189,7 +189,7 @@ export function TransactionListRow(props: Props) { | |||
| }) | |||
|
|
|||
| return ( | |||
| <CardUi4 icon={icon} onPress={handlePress} onLongPress={handleLongPress}> | |||
| <CardUi4 icon={icon} onPress={handlePress} onLongPress={handleLongPress} marginRem={[0.5, 1]}> | |||
There was a problem hiding this comment.
I thought we wanted .5 rem around all components and then a 0.5 padding around the outer-most container component on a scene?
There was a problem hiding this comment.
Yes, ideally, but we're hacking around the fact that SceneHeader was never updated to follow these rules.
There was a problem hiding this comment.
Can you clarify what you mean when you refer to the SceneHeader component?
Jon-edge
force-pushed
the
sam/home-scene-margins
branch
from
1d8a933 to
d7ad861
Compare
samholmes
force-pushed
the
sam/home-scene-margins
branch
2 times, most recently
from
a53c674 to
7b95ff5
Compare
It looks like the SceneWrapper is incorrectly applying padding to scenes with tabs, but rather than fixing the SceneWrapper which is high-risk, just apply the padding manually.
We use the `overflow: 'visible'` rule on this scene to achieve the right margins without losing the ability for the SceneHeader to extend outside of the margins as necessary.
samholmes
force-pushed
the
sam/home-scene-margins
branch
from
7b95ff5 to
dcf83db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: