Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin on BackupModal #4748

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix margin on BackupModal #4748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/modals/BackupModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ const getStyles = cacheStyles((theme: Theme) => ({
alignItems: 'center',
flexDirection: 'column',
justifyContent: 'space-between',
marginTop: theme.rem(2),
height: '100%'
Copy link
Contributor

@swansontec swansontec Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the height: 100% might be the problem. I think we mean flexGrow: 1, so the area expands to fill the modal? Explicit dimensions are a big red flag for layout problems, since they erase the intrinsic content size.

If flexGrow: 1 causes problems, then no worry, we can merge your solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flexGrow causes the image to go away. The best looking version, by just tweaking these styles, is to just remove marginTop

},
image: {
Expand Down
Loading