Fix margin on BackupModal #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peachbits
commented
Jan 23, 2024
•
peachbits
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1206072694496683
|
|
swansontec
approved these changes
Jan 23, 2024
| @@ -82,7 +82,6 @@ const getStyles = cacheStyles((theme: Theme) => ({ | |||
| alignItems: 'center', | |||
| flexDirection: 'column', | |||
| justifyContent: 'space-between', | |||
| marginTop: theme.rem(2), | |||
| height: '100%' | |||
There was a problem hiding this comment.
I think the height: 100% might be the problem. I think we mean flexGrow: 1, so the area expands to fill the modal? Explicit dimensions are a big red flag for layout problems, since they erase the intrinsic content size.
If flexGrow: 1 causes problems, then no worry, we can merge your solution.
There was a problem hiding this comment.
flexGrow causes the image to go away. The best looking version, by just tweaking these styles, is to just remove marginTop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.