Small GUI Fixes #4747
Merged
Small GUI Fixes #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/ui4/fix/small
branch
from
dbc3c14 to
0296747
Compare
swansontec
approved these changes
Jan 23, 2024
| @@ -241,7 +241,7 @@ exports[`TransactionListRow should render with loading props 1`] = ` | |||
| ] | |||
| } | |||
| > | |||
| Synchronizing | |||
| Syncing... | |||
There was a problem hiding this comment.
I think this snapshot change goes with the previous commit.
Jon-edge
force-pushed
the
jon/ui4/fix/small
branch
from
0296747 to
3f092f2
Compare
Jon-edge
force-pushed
the
jon/ui4/fix/small
branch
from
3f092f2 to
7528ac9
Compare
We were inconsistently using ellipses across all languages. For the Asian languages, \u2026 was used which represents a single character width ellipses.
Logic was hiding the right button if onPress wasn't provided
Jon-edge
force-pushed
the
jon/ui4/fix/small
branch
from
7528ac9 to
c8b47db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings scene was not changed, but RowUi4 was. Providing a screen here to show various RowUi4's still work with the rightButtonType changes:
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: