Paul/fix exchange scenes #4739
Merged
Paul/fix exchange scenes #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
paullinator
force-pushed
the
paul/fixExchangeScenes
branch
3 times, most recently
from
85c0699 to
88c4326
Compare
samholmes
requested changes
Jan 22, 2024
| sceneMargin | ||
| /> | ||
| {({ insetStyle }) => ( | ||
| <View style={{ paddingBottom: insetStyle.paddingBottom, width: '100%', height: '100%' }}> |
There was a problem hiding this comment.
Why the extra view instead of using the one with styles.container?
Also, why only use paddingBottom from insetStyle? Using all of the rules usually means we're avoiding insets on left/right and even top sides of the device (e.g. for rotated iPad devices)
There was a problem hiding this comment.
The extra View covers all the content including the button at the bottom while the inner View is just the text and spinner.
I didn't actually need the insets at all since all the content is centered. Removed.
| renderItem={this.renderPlugin} | ||
| keyExtractor={(item: GuiPluginRow) => item.pluginId + item.title} | ||
| contentContainerStyle={{ ...insetStyle, paddingTop: 0 }} | ||
| contentContainerStyle={{ paddingTop: 0 }} |
paullinator
force-pushed
the
paul/fixExchangeScenes
branch
3 times, most recently
from
4e27e11 to
bc0b749
Compare
samholmes
approved these changes
Jan 23, 2024
paullinator
force-pushed
the
paul/fixExchangeScenes
branch
from
bc0b749 to
0dcfcb5
Compare
|
/rebase |
github-actions
bot
force-pushed
the
paul/fixExchangeScenes
branch
from
0dcfcb5 to
f486edc
Compare
paullinator
force-pushed
the
paul/fixExchangeScenes
branch
from
f486edc to
f351efc
Compare
This allows the header to be transparent on scroll. Also just uses less views.
- Add animations - Fix margin above Next button - Make Next button primary
- Add animation - Increase font size - Decrease long wait time to 10s
- Use the SceneWrapper scrollview - Add animations - Reduce slider marginTop
And use the SceneWrapper so content can go under translucent header
paullinator
force-pushed
the
paul/fixExchangeScenes
branch
from
f351efc to
46db58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: