UI4: Card & Row Components #4593
Conversation
| // TODO: Adjust margin/padding so everything combines with correct layout no | ||
| // matter the combination of UI4 components. |
There was a problem hiding this comment.
Ambitious. I assume this will happen later as more stuff gets built out?
There was a problem hiding this comment.
Yes, I tried to start doing it and then found I had to make more changes upon tackling subsequent tasks and thinking of new rules for margin handling for sub components.
Figured it would be better to just handle it at the end to make sure everything works and avoid all the rebasing, it's already almost there at this point.
src/theme/variables/edgeDark.ts
Outdated
| @@ -394,5 +397,8 @@ export const edgeDark: Theme = { | |||
| guiPluginLogoMoonpay: guiPluginLogoMoonpay, | |||
|
|
|||
| // UI 4.0: | |||
| cardBackgroundUi4: palette.teal, | |||
| cardRadiusUi4: 1, | |||
There was a problem hiding this comment.
We usually avoid putting dimensions in the theme, and instead rely on rem to scale things.
If we are committed to having the radius in the theme for some reason, then it's weird to do theme.rem(theme.cardRadius). Maybe just return the radius in dp's, not rem's, since the theme controls the scaling already.
There was a problem hiding this comment.
Just checked, and the other theme dimensions are already in raw dp's, such as thinLineWidth or secondaryButtonOutlineWidth.
There was a problem hiding this comment.
This is a rem, I can rename the var
There was a problem hiding this comment.
I don't think it should be rem in the first place, but the rename is also an acceptable solution.
Jon-edge
force-pushed
the
jon/ui4/components
branch
4 times, most recently
from
8a2633d to
f59d9c8
Compare
Jon-edge
force-pushed
the
jon/ui4/components
branch
from
f59d9c8 to
d9405cd
Compare
Largely copied from Tile. - Converted to a functional component - Removes the bottom divider to let the caller handle dividers
Largely copied from Card. - Styled according to UI4 guidelines - Adds new functionality to automatically add styled dividers when multiple children are given.
Jon-edge
force-pushed
the
jon/ui4/components
branch
from
d9405cd to
d95b628
Compare
See branches future'd with this branch for additional visuals.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: