Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum iOS version to 14 #4751

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Bump minimum iOS version to 14 #4751

merged 1 commit into from
Jan 25, 2024

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Jan 23, 2024


Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but did we check with QA / support about this? I guess we can't support a device we can't test on, but nothing in accountbased should prevent the app from running, even if BigInt support is missing. It sounds like we should debug accountbased as well, regardless, since there should be zero library code in the root bundle, just currency infos.

@peachbits
Copy link
Contributor Author

As discussed IRL, edge-exchange-plugins isn't chunked as edge-currency-accountbased is so imported sdks with new fancy features are always present. There's a good performance benefit to eventually adding that to exchange plugins, but since iOS 13 phones are upgradable to iOS 14, this change makes sense for now and exchange plugins can be updated later.

@peachbits peachbits enabled auto-merge January 25, 2024 20:30
@peachbits peachbits merged commit 08ca74c into develop Jan 25, 2024
2 checks passed
@peachbits peachbits deleted the matthew/minIos14 branch January 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants