[DMS-322] Convert Debezium __deleted flagged record to tombstone #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenfuqua
reviewed
Sep 5, 2024
README.md
Outdated
| This transformation checks for a Debezium _deleted=true flag. If found, it turns it into a tombstone | ||
|
|
||
| - `org.edfi.kafka.connect.transforms.DebeziumDeletedToTombstone` | ||
| - works on values. |
There was a problem hiding this comment.
I'm not sure what this implies.
There was a problem hiding this comment.
Me neither, will remove. Copy and paste 🤣
bradbanister
commented
Sep 5, 2024
| record.keySchema(), | ||
| record.key(), | ||
| isDeleted ? null : record.valueSchema(), | ||
| isDeleted ? null : record.value(), |
There was a problem hiding this comment.
Nulling out record value makes it a tombstone
bradbanister
commented
Sep 5, 2024
| <property name="fileExtensions" value="java"/> | ||
| <property name="headerFile" value="${config_loc}/java.header" default="checkstyle/java.header"/> | ||
| </module> | ||
|
|
There was a problem hiding this comment.
Files have different license headers now
bradbanister
force-pushed
the
DMS-322
branch
from
e17cfd5
to
2640a5b
Compare
stephenfuqua
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.