Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dt to TSM #89

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add dt to TSM #89

merged 2 commits into from
Sep 11, 2024

Conversation

sjordan29
Copy link
Contributor

Addressing #79 with a quick fix. This adds a dt variable to TSM, with a default at 1 day to be consistent with NSM. When we merge this PR, we should open an issue to formalize time handling (potentially using xarray simlab).

  • The test comparing the calculations sets this dt parameter at 1/86400 days (1 second) and we get the correct output
  • I updated the notebooks to demonstrate how to use dt.

@sjordan29
Copy link
Contributor Author

Looks like the tests that were failing were remnants of #87, which we discussed and were OK with failing.

I added the @pytest.mark.xfail(reason="Known issue with kbod 20 test TBA.") decorator to these. This should ensure the pipeline passes but still flags the failing tests. Can @imscw95 or @aufdenkampe open an issue detailing the status of the test that's failing?

@sjordan29 sjordan29 requested a review from kewalak August 14, 2024 14:13
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (ca28ae8) to head (eaf0b58).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   80.62%   89.13%   +8.50%     
==========================================
  Files          27       25       -2     
  Lines        1843     1712     -131     
==========================================
+ Hits         1486     1526      +40     
+ Misses        357      186     -171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjordan29
Copy link
Contributor Author

I'll be out of office until 9/12. @imscw95, if you get a chance to review and all looks OK - feel free to merge to main. Otherwise, we can resolve when I return. Thanks!

@aufdenkampe aufdenkampe added this to the NSM Initial Release milestone Sep 10, 2024
@imscw95 imscw95 merged commit 20d82b8 into main Sep 11, 2024
2 checks passed
@aufdenkampe aufdenkampe deleted the tsm-dt-variable branch September 23, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants