Skip to content

Commit

Permalink
EEH-2488 - Removed CV constraint on Assay instrument platforms
Browse files Browse the repository at this point in the history
We decided to loose the constraint so that we wouldn't be required to update a never ending CV list, and also to work around elixir-europe/biovalidator#56
  • Loading branch information
M-casado committed Jan 11, 2023
1 parent a56e072 commit d409848
Showing 1 changed file with 4 additions and 28 deletions.
32 changes: 4 additions & 28 deletions schemas/EGA.common-definitions.json
Original file line number Diff line number Diff line change
Expand Up @@ -2916,7 +2916,7 @@
"type": "string",
"title": "Assay's instrument category",
"meta:propertyCurie": "EFO:0002773",
"description": "The general categories (e.g. sequencers) in which assay instruments are categorized. Term chosen from a list of controlled vocabulary (CV). If you cannot find your term in the CV list, please create an issue at our [metadata GitHub repository](https://github.com/EbiEga/ega-metadata-schema/issues/new/choose) proposing its addition.",
"description": "The general categories (e.g. sequencer) in which assay instruments are categorized. Term chosen from a list of controlled vocabulary (CV). If you cannot find your term in the CV list, please create an issue at our [metadata GitHub repository](https://github.com/EbiEga/ega-metadata-schema/issues/new/choose) proposing its addition.",
"enum": [ "array", "sequencer" ],
"meta:enum": {
"array": "[EFO:0002698][Array instrument](http://www.ebi.ac.uk/efo/EFO_0002698), an instrument which consists of nucleic acid or protein molecules bound to a substrate",
Expand All @@ -2925,36 +2925,12 @@
},
"assayInstrumentPlatform": {
"type": "string",
"title": "Assay instrument label",
"description": "Label (e.g. 'Illumina HiSeq 2500'), chosen from a list of controlled vocabulary (CV), of the technology used at the experiment. If you cannot find your term in the CV list, please create an issue at our [metadata GitHub repository](https://github.com/EbiEga/ega-metadata-schema/issues/new/choose) proposing its addition.",
"title": "Assay instrument platform",
"description": "Platform of the used instrument (e.g. 'Illumina HiSeq 2500'). Given the heterogenity in sequencing and array platforms (power of thousands), this property is not restricted by a CV list (i.e. it is free text).",
"minLength": 1,
"examples": ["Illumina HiSeq 2500", "[HuGene-1_1-st] Affymetrix Human Gene 1.1 ST Array [probe set (exon) version]", "DNBSEQ-G400 FAST"]
}
},
"oneOf": [
{
"title": "Asserting array technology controlled vocabulary (CV)",
"properties": {
"assayInstrument": {
"enum": [ "array" ]
},
"assayInstrumentPlatform": {
"$ref": "./controlled_vocabulary_schemas/EGA.cv.instrument_platforms_array.json"
}
}
},
{
"title": "Asserting sequencer technology controlled vocabulary (CV)",
"properties": {
"assayInstrument": {
"enum": [ "sequencer" ]
},
"assayInstrumentPlatform": {
"$ref": "./controlled_vocabulary_schemas/EGA.cv.instrument_platforms_sequencing.json"
}
}
}
]
}
},

"libraryLayout": {
Expand Down

0 comments on commit d409848

Please sign in to comment.