Fix compiler warnings, bump deps etc. #3318
Merged
+284
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Window/Scenes
FileFinder
Audio
Battle
Wii
3DS
PSVita
Switch
libretro
|
correction: The PR labeler works. So many colourful labels 😆 |
Ghabry
removed
Window/Scenes
FileFinder
Audio
Battle
Wii
3DS
PSVita
Switch
libretro
github-actions
bot
added
Audio
Battle
Wii
3DS
PSVita
Switch
libretro
fdelapena
removed
Android
Window/Scenes
FileFinder
Audio
Battle
Wii
3DS
PSVita
Switch
MIDI
libretro
|
uhm will also disable the sanitizers for now. looks like the leak sanitizer makes the check fail... |
Ghabry
force-pushed
the
cleanup
branch
2 times, most recently
from
5eb18da to
7d78303
Compare
carstene1ns
reviewed
Jan 8, 2025
src/game_battlealgorithm.cpp
Outdated
| @@ -62,9 +62,12 @@ Game_BattleAlgorithm::AlgorithmBase::AlgorithmBase(Type ty, Game_Battler* source | |||
| type(ty), source(source), targets(std::move(in_targets)) | |||
| { | |||
| assert(source != nullptr); | |||
|
|
|||
| #ifndef NDEBUG | |||
There was a problem hiding this comment.
Does it nag about an empty loop here?
Because asserts are no-ops in release builds anyway, so should be optimized away.
There was a problem hiding this comment.
It nags about the unused t loop var when the assert is removed.
There was a problem hiding this comment.
Found a better solution involving assert(std::none_of(...)).
|
good news: Can reenable the sanitizers. The reported memory leak was a real leak (I assumed its a false positive because of some static buffers in liblcf). The destiny testcase used |
fdelapena
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My final contribution before Christmas to get rid of all compiler warnings reported by g++ and clang with
Wall, extra, deprecated.Can be already reviewed, except:
Unfortunately: This is not ready yet because the unit tests that calculate the attack damage fail. The reason is that the tests never executed because
SUBCASEs inside a for-loop only executed once. Now they run and fail 🤷 .I think the code itself is correct, just the tests are flawed and nobody noticed as they didn't execute. But fixing this is a bit more involved.