Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wii mixer and logging cleanup #3181

Merged
merged 4 commits into from
Jan 5, 2024
Merged

add wii mixer and logging cleanup #3181

merged 4 commits into from
Jan 5, 2024

Conversation

carstene1ns
Copy link
Member

tested on wii, linux
untested on windows, macos, android, emscripten, 3ds, psvita, switch

Some notes:

  • Wii plays music now directly with DSP, no abstraction over SDL.
  • Color log messages are always enabled now, rang did check for a valid terminal (isatty), but I figured nobody redirects player output to file, when there is a logfile. fmt has no support for old terminals on windows, if this is a problem, we can disable colors for these later
  • Android logs are cleaner now in release builds
  • 3DS should be able to log over network now (untested, copied from switch)

@carstene1ns
Wii: use custom audio backend
93a30cd 
Wii: support log messages in dolphin
audio_generic: fix source permissions
@carstene1ns carstene1ns added this to the 0.8.1 milestone Dec 31, 2023
@carstene1ns
Rewrite custom logging (again)
232cfd1 
Use a callback function to output log strings on certain platforms.
Clean up output.cpp
More verbose initial startup logging on Homebrew targets.
Remove rang dependency, coloring is now done by fmt.
@carstene1ns
Output: Make coloring compatible with fmt 6-8
4f6d357
@carstene1ns
Update workflow and CMake config
4bc9cfb 
Minimum supported is CMake version 3.16 now
Drop fmt 5 support with debian 10, only retropie left
@Ghabry Ghabry merged commit c9ed891 into EasyRPG:master Jan 5, 2024
13 checks passed
@Ghabry
Copy link
Member

Ghabry commented Jan 5, 2024

fmt has no support for old terminals on windows

Well the release build on Windows has no "console subsystem" so you will not see them anyway when you are not programming. xD

@carstene1ns carstene1ns deleted the wii-mixer-and-output branch January 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghabry Ghabry Ghabry approved these changes

@fdelapena fdelapena fdelapena approved these changes

Assignees
No one assigned
Labels
3DS Android Emscripten WebAssembly/JavaScript port for web browsers PSVita Refactor Switch Wii WiiU
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@carstene1ns @Ghabry @fdelapena