FreeType: Calculate font size correctly depending on whether it is a pixel or a truetype font. #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very very good news: I figured out why the spacing was wrong (glyphs too close to each other): Rounding error :/ @Mimigris guess this resolves your "custom spacing option" request. As there is no need for it anymore :)
New compared to RPG_RT:
The 3rd case has different metrics but otherwise it matches perfectly :) |
fdelapena
reviewed
Dec 24, 2023
…pixel or a true type font. Fix small rendering issues. Fix EasyRPG#2953
Finally looks very close to Windows.
fdelapena
approved these changes
Dec 24, 2023
|
I changed the rounding algorithm for better accuracy (round instead of ceil works better). The metrics are now shown in the message boxes below. This is ready Noto Sans Mono:
Mother 12px Font: (one small mismatch in the 2nd row)
|
carstene1ns
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Goburinbro
Fix #2953
Player before:
Player after:
RPG_RT: