Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap MPAS longitude values to [0,2pi) range #23

Closed

Commits on Jul 18, 2024

  1. Wrap MPAS longitude values to [0,2pi) range

    This commit addresses issues that were seen when using ncdata with
    longitudes in the [-pi, pi] range in cases with full physics.  This
    would cause the atmosphere to become unphysical and runs to fail. This
    change is made just after the longitude values are read to ensure they
    are correct for the remainder of execution.
    gdicker1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e988f4f View commit details
    Browse the repository at this point in the history
  2. Add initial ChangeLog after making PR

    NOTE: this is before the 'aux_cam' tests have been run
    gdicker1 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7edc1db View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Remove unused nCells from cam_mpas_read_static

    Previous versions of the lonCell_arr adjustment used an explicit loop. Without this loop, the nCells variable and the routine to fetch it are no longer needed.
    gdicker1 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f3dfa51 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Add kind to number literal in lonCell_arr adjustment

    Makes code consistent with CAM coding standards: 'All variables of type
    real must have a specified kind, including literals.'
    gdicker1 committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    288f3ed View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Move lonCell wrap code to dyn_grid.F90 from cam_mpas_subdriver.F90

    This commit also extends the comment that was with this code block,
    includes an if condition so valid values aren't modified, uses kinds and
    constants (pi) that are already used in the new file, and updates the
    ChangeLog so the correct file is referenced.
    gdicker1 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fabe37a View commit details
    Browse the repository at this point in the history
  2. Replace .ge. with >= in lonCell loop condition

    Conform to CAM Coding Standards: 'Use symbolic numerical comparison
    operators (e.g., ==, /=, <, >=) not old character versions (e.g.,
    .eq.).'
    gdicker1 committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    005e7f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1325911 View commit details
    Browse the repository at this point in the history