Created a testing suite to enable validation of Fts and other parameters #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should also remove the caluclation of any "Rs" term at this stage to avoid confusion
I think we still need to figure out how to handle minerals other than zircon and apatite
I didn't change anything here, just noted that the Ft values and uncertainties need to reference the corrected values we calculated in the icpms importer
* test-datasets: (23 commits) Got test to fail due to differing Ft values Test that grain ages are correct Created a passing test Created a passing test Started splitting plugins from analytical files Broke picking file import into separate file Inproved test datasets Created a local Python environment and a no-op test Added some test data Updated gitignore and port mapping Added local changes Added query_analyst function Fixed some remaining bad imports Made prestart script more predictable Got rid of some stray merge markers Added some straggling changes Updated imports for new Sparrow version Removed unused gitmodules Adjusted gitattributes Update publication file ...
* patch-1: Starting point for new Ft calculations Reformatted code Partial changes Small update Unwrapped some pseudocode for pickingImport Update dataReduction.py Update icpmsImport.py Update pickingImport.py
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test