Check for valid output directory for FieldGenerator methods that write files #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add checks using
std::filesystem
to check that theoutdir
parameter passed toFieldGenerator::file_lines
,FiledGenerator::file_slices
, andFieldGenerator::file_volumes
is valid and throw a standard exception rather than terminate if the provided directory does not exist.Tested by providing valid and invalid directories to
FieldGenerator::file_volumes
.Comment
I also note that the standalone vtk volume writer appears to have transposed axes. Need to check this. The
pyEXP.fields.volumes
provides a 3-tensor that needs to be converted from column-major to row-major, but otherwise looks correct.