Feature/move smart charging handlers and callbacks to functional block #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
… the same class). Fix tests. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/move-smart-charging-handlers-and-callbacks-to-functional-block
branch
from
702147a to
e95572a
Compare
marcemmers
requested changes
Jan 31, 2025
Comment on lines
+74
to
+75
| virtual ~SmartChargingInterface() { | ||
| } |
There was a problem hiding this comment.
Suggested change
| virtual ~SmartChargingInterface() { | |
| } | |
| virtual ~SmartChargingInterface() = default; |
I would just leave it like this
| /// \param duration How long the schedule should be | ||
| /// \param unit ChargingRateUnit to thet the schedule for | ||
| /// \return the composite schedule if the operation was successful, otherwise nullopt | ||
| virtual std::optional<CompositeSchedule> get_composite_schedule(int32_t evse_id, std::chrono::seconds duration, |
There was a problem hiding this comment.
I can imagine consumers don't always need to get all the schedules so it might be better to leave these in. We use the latter of these function to get a schedule.
| @@ -200,7 +200,7 @@ std::vector<ChargingProfilePurposeEnum> get_purposes_to_ignore(const std::string | |||
| std::vector<ChargingProfilePurposeEnum> purposes_to_ignore; | |||
| const auto purposes_to_ignore_vec = split_string(csl, ','); | |||
|
|
|||
| for (const auto purpose : purposes_to_ignore_vec) { | |||
| for (const auto& purpose : purposes_to_ignore_vec) { | |||
There was a problem hiding this comment.
It is a vector of enums, so no need to take by reference (enum is only 4 bytes anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move smart charging handlers and callbacks to a new smart charging functional block.
Issue ticket number and link
#953
Checklist before requesting a review