Skip to content

Apply review comments

Codacy Production / Codacy Static Code Analysis required action Aug 16, 2024 in 0s

26 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 26
           

Complexity increasing per file
==============================
- everest_dev_tool/src/everest_dev_tool/parser.py  2
- everest_dev_tool/src/everest_dev_tool/services.py  5
- everest_dev_tool/src/everest_dev_tool/git_handlers.py  2
- everest_dev_tool/src/everest_dev_tool/__init__.py  1

See the complete overview on Codacy

Annotations

Check notice on line 11 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L11 

Expected: 80; Actual: 126

Check notice on line 15 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L15 

Expected: 80; Actual: 110

Check notice on line 31 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L31 

Expected: 80; Actual: 101

Check notice on line 31 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L31 

Lists should be surrounded by blank lines

Check notice on line 32 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L32 

Expected: 80; Actual: 98

Check notice on line 42 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L42 

Expected: 80; Actual: 103

Check notice on line 46 in README.md

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

README.md#L46 

Expected: 80; Actual: 136

Check warning on line 17 in devcontainer/setup-devcontainer.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/setup-devcontainer.sh#L17 

Double quote to prevent globbing and word splitting.

Check warning on line 19 in devcontainer/setup-devcontainer.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/setup-devcontainer.sh#L19 

Double quote to prevent globbing and word splitting.

Check warning on line 36 in devcontainer/setup-devcontainer.sh

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/setup-devcontainer.sh#L36 

Double quote to prevent globbing and word splitting.

Check failure on line 5 in devcontainer/template/.devcontainer/general-devcontainer/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/template/.devcontainer/general-devcontainer/Dockerfile#L5 

Do not use sudo as it leads to unpredictable behavior. Use a tool like gosu to enforce root

Check notice on line 15 in devcontainer/template/.devcontainer/general-devcontainer/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/template/.devcontainer/general-devcontainer/Dockerfile#L15 

Double quote to prevent globbing and word splitting.

Check notice on line 16 in devcontainer/template/.devcontainer/general-devcontainer/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/template/.devcontainer/general-devcontainer/Dockerfile#L16 

Double quote to prevent globbing and word splitting.

Check notice on line 17 in devcontainer/template/.devcontainer/general-devcontainer/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

devcontainer/template/.devcontainer/general-devcontainer/Dockerfile#L17 

Double quote to prevent globbing and word splitting.

Check warning on line 3 in everest_dev_tool/src/everest_dev_tool/git_handlers.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/git_handlers.py#L3 

Consider possible security implications associated with the subprocess module.

Check warning on line 16 in everest_dev_tool/src/everest_dev_tool/git_handlers.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/git_handlers.py#L16 

subprocess call - check for execution of untrusted input.

Check notice on line 3 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L3 

Multiple imports on one line (os, sys) (multiple-imports)

Check warning on line 4 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L4 

Consider possible security implications associated with the subprocess module.

Check warning on line 51 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L51 

subprocess call - check for execution of untrusted input.

Check notice on line 79 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L79 

'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)

Check warning on line 79 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L79 

subprocess call - check for execution of untrusted input.

Check notice on line 80 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L80 

Module 'docker' has no 'from_env' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects. (c-extension-no-member)

Check notice on line 103 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L103 

Unused argument 'log' (unused-argument)

Check warning on line 174 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L174 

subprocess call - check for execution of untrusted input.

Check warning on line 188 in everest_dev_tool/src/everest_dev_tool/services.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

everest_dev_tool/src/everest_dev_tool/services.py#L188 

subprocess call - check for execution of untrusted input.
View more details on Codacy Production