Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency manager didn't pull the latest releases #35

Open
A-thaVan opened this issue Dec 8, 2023 · 1 comment
Open

Dependency manager didn't pull the latest releases #35

A-thaVan opened this issue Dec 8, 2023 · 1 comment
Labels

Comments

@A-thaVan
Copy link

A-thaVan commented Dec 8, 2023

When I ran edm init main --workspace ~/checkout/everest-workspace, it didn't pull the latest release for everest-framework. The CMakeLists.txt file still showed a version # of 0.8.1 and I had to comment out some deprecated lines of code related node_api_version to compile properly.

Not sure if this version control is intended behaviour.

@andistorm
Copy link
Contributor

Thanks for reporting @A-thaVan!

I am not sure about your intention:

  • a) You want to checkout the latest release:
    that would mean not checking out all the main branches but the latests tagged version of everest-core and the dependencies described in its dependencies.yaml:
    https://github.com/EVerest/everest-core/blob/2023.10.0/dependencies.yaml (v0.8.0 for everest-framework in this case)
  • b) Checking out the current main branch to have a good starting point for development:
    In this case your command doesn't result in such a good starting point as already adressed in Simplify usage of edm init for development usecases #33
    So the behaviour of edm is here to checkout everest-core's main branch and the versions defined in dependencies.yaml which is right now a non human readable git revision:
everest-framework:
  git: https://github.com/EVerest/everest-framework.git
  git_tag: a233ec8
  options: ["BUILD_TESTING OFF"]

This revsion is not the current main for everest-framework. It includes the version 0.8.1 in its CMakeLists.txt

Feel free to comment if you have any further questions on this matter.

@andistorm andistorm added the devex label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants