Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git error messages when using a ref instead of a branch #34

Open
DerMolly opened this issue Dec 8, 2023 · 0 comments
Open

git error messages when using a ref instead of a branch #34

DerMolly opened this issue Dec 8, 2023 · 0 comments
Labels

Comments

@DerMolly
Copy link

DerMolly commented Dec 8, 2023

Currently we get an error messages when running edm init if one of the repos is pinned to ref instead of a branch or tag.

[edm]: Setting up dependency "libslac" in workspace
[edm]:    Error while cloning git repository during local dependency checkout:
[edm]:       Cloning into '/Users/molly/Developer/pionix/everest/libslac'...
[edm]:       fatal: Remote branch 486cd8b not found in upstream origin
[edm]:     No git_rev given, but git_tag "486cd8b" might be a git_rev, trying to checkout this rev.
[edm]:     Successfully checked out git_rev "486cd8b" of dependency "libslac"

This behaviour is confusing because, there is no actual error, but edm reports it as such. (Well git does, but we take this as your own message here)

In the future there should be not error when this happens. It could be benefical to warn the user that this was happened, as we should try to keep branch and tags and not git refs pinned, but this is not strictly necessary imho.

@andistorm andistorm added the devex label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants