Feature/890 move reservations callbacks and handlers to new functional block #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
7196517 to
37257b1
Compare
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
from
5a9b1b2 to
c69d3ff
Compare
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
37257b1 to
19ae787
Compare
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
from
c69d3ff to
2dab2f2
Compare
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
19ae787 to
37f9f0d
Compare
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
8 times, most recently
from
71f4998 to
437fbea
Compare
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
f10def8 to
9c9f185
Compare
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
from
437fbea to
8f32979
Compare
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
2 times, most recently
from
47b7f5d to
4314efc
Compare
Base automatically changed from
feature/958-reservation-all-connectors-reserved
to
main
December 16, 2024 11:59
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
2 times, most recently
from
37719d7 to
893a32d
Compare
Pietfried
approved these changes
Dec 17, 2024
dependencies.yaml
Outdated
| @@ -67,7 +67,7 @@ libevse-security: | |||
| # OCPP | |||
| libocpp: | |||
| git: https://github.com/EVerest/libocpp.git | |||
| git_tag: e52ac969095804144af4896af1984cedaf45a3f8 | |||
| git_tag: feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block | |||
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
from
893a32d to
2a660ee
Compare
…mentation in libocpp when reservations is not available in the device model. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
from
2a660ee to
1571152
Compare
maaikez
deleted the
feature/890-move-reservations-callbacks-and-handlers-to-new-functional-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Change test because behaviour of reservations slightly changed when reservations is not available ('NotImplemented' is returned when a ReserveNow request is performed from a CSMS).
This is now rebased on #958 and should be rebased to main before merging and merged after #958 .
Issue ticket number and link
Checklist before requesting a review