Release 1.5.0 #54
Merged
Release 1.5.0 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
release-1.5.0
branch
2 times, most recently
from
04d02a7 to
20992ee
Compare
Also revamped our CI to build the package once and test many times, and publish GitHub release on deploy.
nicoddemus
force-pushed
the
release-1.5.0
branch
from
20992ee to
2035cf9
Compare
prusse-martin
approved these changes
Jan 11, 2024
tadeu
approved these changes
Jan 11, 2024
Comment on lines
-9
to
-16
| [testenv:linting] | ||
| skip_install = True | ||
| basepython = python3.7 | ||
| deps = pre-commit>=1.11.0 | ||
| commands = pre-commit run --all-files --show-diff-on-failure | ||
|
|
||
| [flake8] | ||
| max-line-length = 100 |
There was a problem hiding this comment.
Just to know, is this not necessary anymore? Linting is being called in another way?
There was a problem hiding this comment.
I decided to drop it and let "black" take care of that for us, and in case some comment goes over that border a bit I do not find a big deal either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the opportunity to modernize things: