Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASIM-5869] - Add water specific enthalpy for constant PVT #422

Closed
wants to merge 0 commits into from

Conversation

BeneBr
Copy link
Contributor

@BeneBr BeneBr commented Jan 31, 2025

Description

Add the water specific enthalpy property for constant PVT description.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@BeneBr BeneBr requested a review from eniohayashi January 31, 2025 11:18
@BeneBr BeneBr force-pushed the fb-ASIM-5869-constant_pvt_table branch from 023106e to 8186410 Compare February 3, 2025 11:01
@caio-ramos
Copy link
Contributor

Actually, following the procedure defined in create_constant, the water enthalpy is a function of the water density and water thermal capacity, which are parameters already given by the user. Thus, if we want to keep the previous behavior of create_constant, the user should not give such a property.

@BeneBr BeneBr force-pushed the fb-ASIM-5869-constant_pvt_table branch from 8186410 to 6d3ec72 Compare February 3, 2025 12:54
Copy link

sonarqubecloud bot commented Feb 3, 2025

@BeneBr
Copy link
Contributor Author

BeneBr commented Feb 3, 2025

Base in the Caio's comment: #422 (comment). This property is no longer needed to be added. This will be calculated internally by calc. So i will close this PR.

@BeneBr BeneBr closed this Feb 3, 2025
@BeneBr BeneBr force-pushed the fb-ASIM-5869-constant_pvt_table branch from 6d3ec72 to 4a3ad24 Compare February 3, 2025 18:50
@BeneBr BeneBr deleted the fb-ASIM-5869-constant_pvt_table branch February 4, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants