Constant PVT Table #416
Merged
Constant PVT Table #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
3 times, most recently
from
707e8e7 to
eb832ef
Compare
caio-ramos
commented
Jan 2, 2025
caio-ramos
requested review from
BeneBr,
alexandrebbruno,
marinhoeng and
eniohayashi
caio-ramos
commented
Jan 2, 2025
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
2 times, most recently
from
dcbfd0f to
8982476
Compare
prusse-martin
approved these changes
Jan 2, 2025
nicoddemus
approved these changes
Jan 3, 2025
marinhoeng
approved these changes
Jan 3, 2025
tests/alfacase/test_generate_list_of_units/test_generate_list_of_units_specific_energy_.txt
Show resolved
Hide resolved
alexandrebbruno
approved these changes
Jan 3, 2025
eniohayashi
reviewed
Jan 3, 2025
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
a020699 to
c0d1796
Compare
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
c0d1796 to
689ddf0
Compare
- Implements `PvtModelConstantPropertiesDescription` - Refactoring of `PvtModelPtTableParametersDescription` - Add extra units - Adds and fixes tests ASIM-5868
caio-ramos
force-pushed
the
fb-ASIM-5868-const-PVT-table-model
branch
from
689ddf0 to
5c5db0a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the features required to allow https://github.com/ESSS/alfasim/pull/796 work properly.
A new PVT model description is added, so user-defined properties can be stored and used to generate a PVT Table with constant properties.