Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add historic curves to the History Matching results metadata #394

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add historic curves to the History Matching results metadata #394

merged 1 commit into from
Jul 23, 2024

Conversation

ro-oliveira95
Copy link
Contributor

@ro-oliveira95 ro-oliveira95 marked this pull request as ready for review July 16, 2024 22:00
nicoddemus
nicoddemus approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changelog entry?

@ro-oliveira95
Copy link
Contributor Author

I think so, to be explicit about the new information available on the results. Will do that.

@ro-oliveira95
Copy link
Contributor Author

ro-oliveira95 commented Jul 19, 2024 •
edited
Loading

@nicoddemus @prusse-martin could you please have a look on the last incoming changes (tests, some restructuring of the HistoryMatchingMetadata class and changelog entry) to see if its all good?

@ro-oliveira95 ro-oliveira95 force-pushed the fb-ASIM-5713-error-deleting-historic-data-curves branch from 4193bf0 to 388f7f4 Compare July 23, 2024 14:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ro-oliveira95 ro-oliveira95 merged commit c6a88dc into master Jul 23, 2024
12 checks passed
@ro-oliveira95 ro-oliveira95 deleted the fb-ASIM-5713-error-deleting-historic-data-curves branch July 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@prusse-martin prusse-martin prusse-martin approved these changes

@BeneBr BeneBr BeneBr approved these changes

@cauebs cauebs Awaiting requested review from cauebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ro-oliveira95 @nicoddemus @prusse-martin @BeneBr