Convert score casings from SCORE to alfacase #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 18, 2024 16:10
PWPA-1933
PWPA-1933
Fill casing and open hole data to create description; Read casing materials; Add new constants for missing valus; Add new unit for roughness; PWPA-1933
PWPA-1933
PWPA-1933
PWPA-1933
gabrielantao
force-pushed
the
fb-PWPA-1933-convert-score-casings
branch
from
8f78504 to
502b4e6
Compare
Fix the typing standard; PWPA-1933
gabrielantao
force-pushed
the
fb-PWPA-1933-convert-score-casings
branch
from
502b4e6 to
000406b
Compare
ckiyono
reviewed
Jun 20, 2024
src/alfasim_score/converter/alfacase/_tests/test_convert_casing.py
Outdated
Show resolved
Hide resolved
Change the casing enumeration schema; PWPA-1933
gabrielantao
force-pushed
the
fb-PWPA-1933-convert-score-casings
branch
from
000a6f1 to
91fb652
Compare
ckiyono
requested changes
Jun 21, 2024
src/alfasim_score/converter/alfacase/_tests/test_convert_casing.py
Outdated
Show resolved
Hide resolved
ckiyono
reviewed
Jun 21, 2024
src/alfasim_score/converter/alfacase/_tests/test_convert_casing.py
Outdated
Show resolved
Hide resolved
ckiyono
requested changes
Jun 21, 2024
gabrielantao
force-pushed
the
fb-PWPA-1933-convert-score-casings
branch
from
c4299ce to
3715d8c
Compare
ckiyono
approved these changes
Jun 21, 2024
| start_position = data["final_md"] | ||
| return open_hole | ||
|
|
||
| def _convert_casings(self) -> WellDescription: |
There was a problem hiding this comment.
Suggested change
| def _convert_casings(self) -> WellDescription: | |
| def _convert_casings(self) -> CasingDescription: |
There was a problem hiding this comment.
Is job passing?
Isn't it dectect locally?
If so, check why.
carlosnewmar
approved these changes
Jun 21, 2024
| start_position = data["final_md"] | ||
| return open_hole | ||
|
|
||
| def _convert_casings(self) -> WellDescription: |
There was a problem hiding this comment.
Is job passing?
Isn't it dectect locally?
If so, check why.
PWPA-1933
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implemented the loading and conversion of the data for CasingDescription: the lists of packers, tubing, casings and open hole. Some missing parameters were defined with default values and a default fluid was used as a placeholder. The tubing conversion was done here too.
PWPA-1933
PWPA-1931