-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert SCORE well trajectory to alfacase #1
Merged
gabrielantao
merged 7 commits into
master
from
fb-PWPA-1930-convert-score-well-trajectory
Jun 17, 2024
Merged
Convert SCORE well trajectory to alfacase #1
gabrielantao
merged 7 commits into
master
from
fb-PWPA-1930-convert-score-well-trajectory
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PWPA-1930
PWPA-1930
Create convertion class for the alfacase and test; PWPA-1930
PWPA-1930
gabrielantao
force-pushed
the
fb-PWPA-1930-convert-score-well-trajectory
branch
from
June 14, 2024 12:03
7279b74
to
5bb7893
Compare
Fix typing for tuple; Remove untyped definition in first row; PWPA-1930
gabrielantao
force-pushed
the
fb-PWPA-1930-convert-score-well-trajectory
branch
from
June 14, 2024 12:58
5bb7893
to
9499349
Compare
lincrosenbach
approved these changes
Jun 14, 2024
ckiyono
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
carlosnewmar
requested changes
Jun 14, 2024
Use the name in the input file as well name; PWPA-1930
Put reference as zero; PWPA-1930
Quality Gate passedIssues Measures |
carlosnewmar
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements convertion for SCORE well trajectory to alfacase.
PWPA-1930