Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SCORE well trajectory to alfacase #1

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

gabrielantao
Copy link
Contributor

This PR implements convertion for SCORE well trajectory to alfacase.

PWPA-1930

Gabriel Antão added 4 commits June 13, 2024 17:27
Create convertion class for the alfacase and test;

PWPA-1930
@gabrielantao gabrielantao marked this pull request as draft June 13, 2024 20:41
@gabrielantao gabrielantao force-pushed the fb-PWPA-1930-convert-score-well-trajectory branch from 7279b74 to 5bb7893 Compare June 14, 2024 12:03
Fix typing for tuple;
Remove untyped definition in first row;

PWPA-1930
@gabrielantao gabrielantao force-pushed the fb-PWPA-1930-convert-score-well-trajectory branch from 5bb7893 to 9499349 Compare June 14, 2024 12:58
@gabrielantao gabrielantao marked this pull request as ready for review June 14, 2024 13:08
setup.py Show resolved Hide resolved
Copy link

@ckiyono ckiyono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/alfasim_score/converter/alfacase/convert_alfacase.py Outdated Show resolved Hide resolved
src/alfasim_score/converter/alfacase/convert_alfacase.py Outdated Show resolved Hide resolved
src/alfasim_score/converter/alfacase/convert_alfacase.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
Use the name in the input file as well name;

PWPA-1930
Put reference as zero;

PWPA-1930
Copy link

Copy link
Contributor

@carlosnewmar carlosnewmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@gabrielantao gabrielantao merged commit 959cb6d into master Jun 17, 2024
14 checks passed
@gabrielantao gabrielantao deleted the fb-PWPA-1930-convert-score-well-trajectory branch June 17, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants