Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diag_table file suffixes and freqeuncies for test runs #184

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

alperaltuntas
Copy link
Member

Currently, for test runs, diagnostics are being output daily, but the files are created as monthly (and overriden each day). This also causes a mismatch between the datestamps in the filenames (monthly) and the data inside them (daily).

Changes Introduced by this PR for test runs:

  • Diagnostics output files are now created daily.
  • Each file corresponds to a single day, ensuring that the datestamp in the filename matches the actual data within the file.

Fixes: #171.

@alperaltuntas alperaltuntas self-assigned this Aug 20, 2024
Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@alperaltuntas alperaltuntas merged commit dd7a43d into ESCOMP:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to correct history file suffixes for test runs
3 participants