fix obliquity input test in astronomy.F90 #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In one input check it said
obliq
in stead ofobliq_in
.also, to answer the comment with:
QUESTION : ARE THESE THE RIGHT LIMITS ???
I am not sure if the limits should be based on the physically possible values, or on the values for Earth specifically.
Earth's orbital eccentricity has varied between 0 and 0.067 for the past 100 Myr, so maybe a test more like 0 to 0.1 would be more suited?
Earth's obliquity has varied from 22° to 24.5° in the same time period, so a better range to check would be something like 10° to 40°? A negative value would not make sense, I think. It should be between 0° and 180°.
Earth's longitude of perihelion with respect to the moving equinox rotates and librates, so it does vary between 0° and 360°.
I could implement these changes in this pull request if desired.
These are the equivalent lines in
shr_orb_mod.F90
:https://github.com/ESCOMP/CDEPS/blob/8197f05ef2549d3c53e4050c9821a683e2728bab/share/shr_orb_mod.F90#L27-L33
Fixes # (issue)
How Has This Been Tested?
no testing, used github edit feature because I just came across the typo.
Checklist:
make distcheck
passes