Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix obliquity input test in astronomy.F90 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

japhir
Copy link

@japhir japhir commented Dec 13, 2024

Description
In one input check it said obliq in stead of obliq_in.

also, to answer the comment with:
QUESTION : ARE THESE THE RIGHT LIMITS ???

I am not sure if the limits should be based on the physically possible values, or on the values for Earth specifically.

Earth's orbital eccentricity has varied between 0 and 0.067 for the past 100 Myr, so maybe a test more like 0 to 0.1 would be more suited?

Earth's obliquity has varied from 22° to 24.5° in the same time period, so a better range to check would be something like 10° to 40°? A negative value would not make sense, I think. It should be between 0° and 180°.

Earth's longitude of perihelion with respect to the moving equinox rotates and librates, so it does vary between 0° and 360°.

I could implement these changes in this pull request if desired.

These are the equivalent lines in shr_orb_mod.F90:
https://github.com/ESCOMP/CDEPS/blob/8197f05ef2549d3c53e4050c9821a683e2728bab/share/shr_orb_mod.F90#L27-L33

Fixes # (issue)

How Has This Been Tested?
no testing, used github edit feature because I just came across the typo.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

in one input check it said obliq in stead of obliq_in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant