Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cdeps with cam7 nextsw cday changes #2900

Merged

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Dec 4, 2024

Description of changes

Update CDEPS so that CPLHIST cases and test use the "cam7" mode for DATM nextsw_cday_calc. Also change testmods for cam7 tuning mode to use this as well.

Specific notes

Contributors other than yourself, if any:
 @billsacks for the CMEPS update itself

CTSM Issues Fixed (include github issue #):
Fixes #2897

Are answers expected to change (and if so in what way)? For cplhist tests and cam7 tests

Any User Interface Changes (namelist or namelist defaults changes)?
New option in DATM
nextsw_cday_calc (can be cam6 or cam7)

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: Running regular testing

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability non-bfb Changes answers (incl. adding tests) labels Dec 4, 2024
@ekluzek ekluzek added this to the cesm3_0_beta06 milestone Dec 4, 2024
@ekluzek ekluzek self-assigned this Dec 4, 2024
@ekluzek ekluzek mentioned this pull request Dec 5, 2024
3 tasks
@ekluzek ekluzek added the priority: Immediate Highest priority, something that was unexpected label Dec 17, 2024
@ekluzek ekluzek added the blocker another issue/PR depends on this one label Dec 17, 2024
Copy link
Contributor

@olyson olyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this consists mainly of gitmodules updates and I assume testing proves this all works, so I'm signing off on this. I do see nextsw_cday_calc set to cam7 for cam7 land tuning mode and iradsw set to -1 (hourly radiation) which make sense.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 18, 2024

Testing is looking as expected on both Izumi and Derecho. There is one test I corrected for Derecho that I'm retesting. The generate phase failed for a lot of the tests on Izumi, because of running out of space on /fs/cgd/csm, but I think I should be able to rerun those, so currently figuring that part out. Outside of that Izumi is as expected though.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 18, 2024

The SSPMATRIX test on Izumi is failing with this problem. I think this is a problem with the new workflow of saving the case details to a local git repository, and likely will be fixed with the next updates to cime.

2024-12-18 13:10:33: ERROR: Command: 'git -C /scratch/cluster/erik/tests_ctsm5315acl/SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.izumi_intel.clm-ciso_monthly.GC.ctsm5315acl_int commit -m "
ERROR: RUN FAIL: Command '  /scratch/cluster/erik/tests_ctsm5315acl/SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.izumi_intel.clm-ciso_monthly.GC.ctsm5315acl_int/bld/cesm.exe   >> cesm.log.$LID 2>&1 ' failed
See log file for details: /scratch/cluster/erik/tests_ctsm5315acl/SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.izumi_intel.clm-ciso_monthly.GC.ctsm5315acl_int.step0-AD/run/cesm.log.707138.izumi.cgd.ucar.edu.241218-131031"' failed with error 'On branch SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.izumi_intel.clm-ciso_monthly.GC.ctsm5315acl_int
nothing to commit, working tree clean' from dir '/scratch/cluster/erik/tests_ctsm5315acl/SSPMATRIXCN_Ly5_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.izumi_intel.clm-ciso_monthly.GC.ctsm5315acl_int.step0-AD'

@ekluzek ekluzek merged commit 4781b41 into ESCOMP:master Dec 18, 2024
2 checks passed
@ekluzek ekluzek deleted the update_cdeps_with_cam7_nextsw_cday_changes branch December 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker another issue/PR depends on this one enhancement new capability or improved behavior of existing capability non-bfb Changes answers (incl. adding tests) priority: Immediate Highest priority, something that was unexpected
Projects
Status: Done (non release/external)
Status: Done
Development

Successfully merging this pull request may close these issues.

Update CDEPS to bring in DATM change regarding nextsw_cday changing answers in CPLHIST cases
2 participants