Add arbitrary restart hour for UFS #522
Conversation
* add hflx_fire, evap_fire, cpl_fire Co-authored-by: Grant Firl <grant.firl@noaa.gov>
* restart_fh using shr_is_restart_fh_mod * Use is_restart_fh revised to avoid thread-local storage inter-component conflicts
|
@jedwards4b I'm not sure, but I might need an ifdef around the restart_fh logical in |
| @@ -179,6 +189,7 @@ subroutine med_phases_restart_write(gcomp, rc) | |||
| real(R8) :: tbnds(2) ! CF1.0 time bounds | |||
| logical :: isPresent | |||
| logical :: first_time = .true. | |||
| logical :: write_restartfh | |||
| @@ -14,6 +14,9 @@ module med_phases_restart_mod | |||
| use med_phases_prep_glc_mod , only : FBocnAccum2glc_o, ocnAccum2glc_cnt | |||
| use med_phases_prep_rof_mod , only : FBlndAccum2rof_l, lndAccum2rof_cnt | |||
| use pio , only : file_desc_t | |||
| #ifndef CESMCOUPLED | |||
| use shr_is_restart_fh_mod, only : init_is_restart_fh, is_restart_fh, is_restart_fh_type | |||
There was a problem hiding this comment.
This module is missing - did you git add it?
There was a problem hiding this comment.
It should be found in our CDEPS share directory (ufs/cdeps_share) which sits at the UFS-WM CDEPS interface level. This are where we have files these files
dtypes.h
shr_assert_mod.F90
shr_frz_mod.F90
shr_infnan_mod.F90
which are generated via genf90.pl for you (and which we cannot use because of restrictions by CentralOps).
There was a problem hiding this comment.
Looking at directory cdeps/share I see files shr_assert_mod.F90.in, shr_frz_mod.F90.in and shr_infnan_mod.F90.in but no shr_is_restart_fh_mod.F90.in
or shr_is_restart_fh_mod.F90 - that file needs to go in that directory if only to enable github testing of the ufs build.
There was a problem hiding this comment.
So a shr_is_restart_fh_mod.F90 inside of cdeps/share will be enough? It doesn't need to be a ".in" file, right?
|
Yes that should be enough. |
|
I made a PR to ESCOMP/CDEPS to add the required module file. |
Description of changes
Enables UFS to read a list of non-interval restart hours and write restarts when appropriate. This is required for operational implementations.
Incidentally adds new Land model component (LM4) for UFS and modifies CPP metadata for the FBH (fire-behavior model).
Specific notes
Code is added under an CESMCOUPLED flag and accesses share code within the UFS CDEPS share code (ufs/cdeps_share).
See related discussion https://github.com/orgs/esmf-org/discussions/291
Contributors other than yourself, if any:
@NickSzapiro-NOAA
CMEPS Issues Fixed (include github issue #):
ufs-community/ufs-weather-model#2348
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Should not impact CESM
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing