Improve describe_version for git-fleximod #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
requested changes
Aug 9, 2024
describe_version
Outdated
| #!/usr/bin/env python | ||
| """Describes the CESM version and any local modifications""" | ||
|
|
||
| from __future__ import print_function |
There was a problem hiding this comment.
I don't think that you need this line.
There was a problem hiding this comment.
Good point - this was a carry-over from the past version of this. I have removed it.
|
@billsacks We have changed the workflow for cesm - please redirect your PR to the cesm3-alphabranch. Thanks |
I will update it to leverage git-fleximod, but want to use the more extensive python script as a starting point.
billsacks
force-pushed
the
describe_version_git_fleximod
branch
from
b60a54e to
e15bd26
Compare
Thanks for the reminder. I have rebased this and changed the base for this PR. |
jedwards4b
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Until recently, the describe_version script worked with manage_externals. In ca22dbf, @jedwards4b changed it to work with git-fleximod, but in doing so removed some of its features. This PR brings back its original features but changes it to work with git-fleximod.
Specific features this brings are:
cime/scripts, you could run../../describe_versionand it would work the same as if you rancd ../../; ./describe_version)Specific notes
Contributors other than yourself, if any:
Fixes #245
User interface changes?: No
Testing performed (automated tests and/or manual tests): Manual testing of describe_version script