Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS so that not only ss421 gets notified/must approve #74

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

climbfuji
Copy link
Collaborator

Update CODEOWNERS. See in the file itself: "Order is important. The last matching pattern has the most precedence."

See right hand side for a demonstration that the current file is wrong.

Update CODEOWNERS. See in the file itself: "Order is important. The last matching pattern has the most precedence."

See #73 for example.
@climbfuji climbfuji requested a review from ss421 as a code owner September 19, 2024 11:30
@climbfuji
Copy link
Collaborator Author

climbfuji commented Sep 19, 2024

@cacraigucar @climbfuji @dustinswales @gold2718 @grantfirl @mattldawson @mkavulich @mwaxmonsky @nusbaume @peverwhee @svahl991 @MayeulDestouches - tagging you here instead of adding you as reviewers so that you can see the problem yourself.

@climbfuji climbfuji self-assigned this Sep 19, 2024
Copy link
Collaborator

@ss421 ss421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Happy with the change. I think we should remove @MayeulDestouches from the list (or update) because he is no-longer at the UKMO. Perhaps that could be done in a seperate change.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@climbfuji climbfuji merged commit 0aa3039 into main Sep 19, 2024
3 checks passed
@climbfuji climbfuji deleted the bugfix/codeowners branch September 19, 2024 12:57
@climbfuji
Copy link
Collaborator Author

Thanks. Happy with the change. I think we should remove @MayeulDestouches from the list (or update) because he is no-longer at the UKMO. Perhaps that could be done in a separate change.

Good point - do you want to nominate another UKMO representative in addition to yourself?

@ss421
Copy link
Collaborator

ss421 commented Sep 20, 2024

Thanks. Happy with the change. I think we should remove @MayeulDestouches from the list (or update) because he is no-longer at the UKMO. Perhaps that could be done in a separate change.

Good point - do you want to nominate another UKMO representative in addition to yourself?

Yes that would be good. Ill see if I can get someone else that could be added. Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants