-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsideration of Add four wind CF variables #73? #77
Comments
I agree there is an unsatisfying inconsistency here, particularly for the |
For a shorter name, maybe we could use
|
@ncrossette - I do like the names that you propose. |
Is |
@climbfuji - I think |
Following the rules is confusing for a couple reasons.
Following the rules for constructing names: The names would be: |
What is the guideline for putting the medium as a suffix vs prefix, like it's done with these variables?:
|
Fair point. |
At least regarding the suffix/prefix situation regarding |
In #73 we came up with 4 new wind CF variable names: (I approved this before the final choice for the names was chosen!)
I apologize to all concerned who have been implementing the new variables and the work they have done. (In particular @svahl991 @shlyaeva @ncrossette)
The new variables are:
atmosphere_horizontal_streamfunction
: Scalar function describing the stream lines of the windatmosphere_horizontal_velocity_potential
: Scalar potential of the windatmosphere_upward_absolute_vorticity
: The kth component of the curl of the vector wind field. The curl itself is assuming wind is a 3D object.divergence_of_wind
: The (horizontal) divergence of the 2-D vector wind fieldI have a few concerns above these names:
divergence_of_the_wind
(although consistent with the CF understanding that a wind is by definition 2D) is misleading to most model developers who consider the wind as a 3D vector. This becomes problematic in high resolution modelling especially around mountains. It is only a matter of time where someone will naively misuse this name and consider it to mean the 3D divergence. This is why adding "horizontal_" in front would greatly reduce the risk of misuse of the variable.divergence_of_wind
not to be misused.Suggestions
atmosphere_horizontal_streamfunction
->horizontal_streamfunction
atmosphere_horizontal_velocity_potential
->horizontal_velocity_potential
atmosphere_upward_absolute_vorticity
->upward_absolute_vorticity
We need to update the description to include The kth component of the curl of the vector wind field.divergence_of_wind
(keep as is)divergence_of_wind_and_upward_air_velocity
(add this to help clarity - 3D divergence!)The text was updated successfully, but these errors were encountered: