Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap MPAS-A longitudes to [0, 2pi) range #1094

Closed
gdicker1 opened this issue Jul 18, 2024 · 1 comment
Closed

Wrap MPAS-A longitudes to [0, 2pi) range #1094

gdicker1 opened this issue Jul 18, 2024 · 1 comment
Assignees
Labels
answer changing answer changing tag enhancement New feature or request

Comments

@gdicker1
Copy link
Collaborator

gdicker1 commented Jul 18, 2024

What is the feature/what would you like to discuss?

While testing MPAS real-data initial conditions I proposed to add in #1029, F2000dev or F2000climo runs at 480km would fail while FADIAB runs would succeed. The cesm.log* files for failed runs would include many lines like imp_sol: Time step 1.1250000000000E+01 failed to converge ..., the amount of time per timestep would drastically increase, and runs would eventually terminate due to a CRITICAL ERROR: NaN detected in 'w' field. message from MPAS-A.

After a fair bit of trial and error, I think this comes down to some part of CAM expecting longitudes to be in the $[0,2\pi)$ range. This is not expected nor required by MPAS-A, and the MPAS-A *.grid.nc files may have longitudes ranging from $[0,2\pi]$ or $[-\pi, \pi]$ (or possibly even arbitrary radian values/ranges).

This is easily fixed by adding a few lines to put longitudes in the correct range. I propose to add these within cam_mpas_read_static subroutine in the cam_mpas_subdriver.F90 file. Since this will affect all longitude values, this change could affect regression tests.

Is there anyone in particular you want to be part of this conversation?

No response

Will this change (regression test) answers?

Yes

Will you be implementing this enhancement yourself?

Yes

@gdicker1 gdicker1 added enhancement New feature or request answer changing answer changing tag labels Jul 18, 2024
@gdicker1 gdicker1 self-assigned this Jul 18, 2024
@gdicker1 gdicker1 changed the title Wrap MPAS-A longitudes to [0, 2pi] range Wrap MPAS-A longitudes to [0, 2pi) range Jul 18, 2024
@gdicker1
Copy link
Collaborator Author

Closed by merge of #1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant