Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jimmielin committed Dec 10, 2024
1 parent cca6e42 commit f999707
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions src/data/air_composition.F90
Original file line number Diff line number Diff line change
Expand Up @@ -744,10 +744,6 @@ subroutine get_cp_1hd(tracer, inv_cp, cp, factor, active_species_idx_dycore, cpd
end do

if (dry_air_species_num == 0) then
! **TMP** TODO CHECK hplin 9/13/24: this if-clause is always in CAM but was not in CAM-SIMA
! and dry_air_species_num is == 0 in CAM-SIMA as of 10/1/24 which means this clause will
! change answers (?) -- previously in CAM-SIMA there was only a call to get_cp_dry
! and not the two IF-clauses here.
sum_cp = thermodynamic_active_species_cp(0)
else if (present(cpdry)) then
!
Expand Down
2 changes: 1 addition & 1 deletion src/data/registry.xml
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@
standard_name="specific_heat_of_air_used_in_dycore"
units="J kg-1 K-1" type="real" kind="kind_phys"
allocatable="allocatable">
<long_name>Enthalpy or internal energy scaling factor for energy consistency</long_name>
<long_name>specific heat of air used in the dynamical core (enthalpy for pressure-based dynamical cores and internal energy for z-based dynamical cores)</long_name>
<dimensions>horizontal_dimension vertical_layer_dimension</dimensions>
<ic_file_input_names>cp_or_cv_dycore</ic_file_input_names>
</variable>
Expand Down

0 comments on commit f999707

Please sign in to comment.